[PATCH] [llvm-mc] fix 64-bit mode call disassembly to ignore opcode size prefix

Craig Topper craig.topper at gmail.com
Fri May 8 19:25:37 PDT 2015


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:994
@@ +993,3 @@
+    case 0xE9:
+      attrMask ^= ATTR_OPSIZE;
+      insn->immediateSize = 4;
----------------
Why no opcodeType check here? Can't this alias?

================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:1013
@@ +1012,3 @@
+      if (insn-> opcodeType == TWOBYTE){ // breaks lea and three byte ops otherwise
+	attrMask ^= ATTR_OPSIZE;
+	insn->immediateSize = 4;
----------------
The indentation on this line is showing up funny in phabricator

http://reviews.llvm.org/D9573

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list