[lld] r236873 - [ARM] Generation of .ARM.exidx/.ARM.extab sections

[Davide Italiano]

On Fri, May 8, 2015 at 9:48 AM, Hans Wennborg <hans at chromium.org> wrote:
> On Fri, May 8, 2015 at 9:36 AM, Davide Italiano <davide at freebsd.org> wrote:
>> On Fri, May 8, 2015 at 9:04 AM, Leny Kholodov
>> <lkholodov at accesssoftek.com> wrote:
>>> Author: lkholodov
>>> Date: Fri May  8 11:04:11 2015
>>> New Revision: 236873
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=236873&view=rev
>>> Log:
>>> [ARM] Generation of .ARM.exidx/.ARM.extab sections
>>>
>>> This patch provides generation of .ARM.exidx & .ARM.extab sections which are
>>> used for unwinding. The patch adds new content type typeARMExidx for atoms from
>>> .ARM.exidx section and integration of atoms with such type to the ELF
>>> ReaderWriter. exidx.test has been added with checking of contents of .ARM.exidx
>>> section and .ARM.extab section.
>>>
>>> Differential Revision: http://reviews.llvm.org/D9324
>>>
>>>
>>
>> (Apparently) This breaks the build, at least on FreeBSD, on my machine.
>> It looks like there's something slightly wrong here, are you OK with
>> the following patch?
>
> It breaks for me on Linux too, and it's turning a bunch of Chromium
> buildbots red on Windows too:
> http://build.chromium.org/p/chromium.fyi/console?category=win%20clang
>
> I tried your fix locally on Linux and that seems to work. I'd suggest
> either committing that, or reverting right now to get the builders
> back to a good state.
>
> Cheers,
> Hans

Hi,
r236880 is an attempt to fix. Leny, this unbreaks the build and passes
the test suite but if you feel like the proposed fix was wrong feel
free to revert and patch appropriately.

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare