[lld] r236873 - [ARM] Generation of .ARM.exidx/.ARM.extab sections

[Davide Italiano]

On Fri, May 8, 2015 at 9:04 AM, Leny Kholodov
<lkholodov at accesssoftek.com> wrote:
> Author: lkholodov
> Date: Fri May  8 11:04:11 2015
> New Revision: 236873
>
> URL: http://llvm.org/viewvc/llvm-project?rev=236873&view=rev
> Log:
> [ARM] Generation of .ARM.exidx/.ARM.extab sections
>
> This patch provides generation of .ARM.exidx & .ARM.extab sections which are
> used for unwinding. The patch adds new content type typeARMExidx for atoms from
> .ARM.exidx section and integration of atoms with such type to the ELF
> ReaderWriter. exidx.test has been added with checking of contents of .ARM.exidx
> section and .ARM.extab section.
>
> Differential Revision: http://reviews.llvm.org/D9324
>
>

(Apparently) This breaks the build, at least on FreeBSD, on my machine.
It looks like there's something slightly wrong here, are you OK with
the following patch?


davide at ganondorf:/exps/llvm/tools/lld % svn diff
Index: lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h
===================================================================
--- lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h (revision 236873)
+++ lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h (working copy)
@@ -36,7 +36,7 @@

   const AtomLayout *appendAtom(const Atom *atom) override {
     const DefinedAtom *definedAtom = cast<DefinedAtom>(atom);
-    assert(atom->contentType() == DefinedAtom::typeARMExidx &&
+    assert(definedAtom->contentType() == DefinedAtom::typeARMExidx &&
            "atom content type for .ARM.exidx section has to be typeARMExidx");

     DefinedAtom::Alignment atomAlign = definedAtom->alignment();
Index: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp


-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare