[PATCH] [Msan] Fix the pthread_getattr_np_deadlock.cc to build and pass on FreeBSD

Evgeniy Stepanov eugenis at google.com
Fri May 8 09:18:49 PDT 2015


XFAIL sounds good, or just move it to Linux.


On Fri, May 8, 2015 at 4:47 AM, Viktor Kutuzov
<vkutuzov at accesssoftek.com> wrote:
> ================
> Comment at: test/msan/pthread_getattr_np_deadlock.cc:15
> @@ -9,2 +14,3 @@
>    pthread_attr_t attr;
> +  pthread_attr_init(&attr);
>    int res = pthread_getattr_np(pthread_self(), &attr);
> ----------------
> eugenis wrote:
>> #ifdef __FreeBSD__
>>
>> The point of the test is to have the first memory allocation in a thread to happen inside pthread_getattr_np.
> It ends up with segfault without the pthread_attr_init() call on FreeBSD. Should we just XFAIL this test?
>
> http://reviews.llvm.org/D9553
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>



More information about the llvm-commits mailing list