[PATCH] [DebugInfo] Add debug locations to constant SD nodes continued

[Sergey Dmitrouk]

Hi echristo, dblaikie, rengolin,

Several updates for `[DebugInfo] Add debug locations to constant SD nodes` (r235989).
Includes:

  - re-enabling the change (disabled recently);
  - missing change for FP constants;
  - resetting debug location of constant node if it's used more than at one place to prevent emission of wrong locations in case of coalesced constants;
  - a couple of additional tests.

Now all look ups in `CSEMap` are wrapped by additional method. Not sure if it makes
sense in all cases, but at least this way we won't miss anything. 

Possible question: why debug location isn't last parameter with default value in the
new method? Answer: because `InsertPos` is output parameter.

Comment in D9084 suggests that debug locations aren't useful for "target constants",
so there might be one more change related to this API (namely, dropping debug
locations for `getTarget*Constant` methods).

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9604

Files:
  include/llvm/CodeGen/SelectionDAG.h
  include/llvm/CodeGen/SelectionDAGNodes.h
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  test/DebugInfo/AArch64/constant-dbgloc.ll
  test/DebugInfo/ARM/constant-dbgloc.ll
  test/DebugInfo/ARM/multiple-constant-uses-drops-dbgloc.ll
  test/DebugInfo/ARM/single-constant-use-preserves-dbgloc.ll
  test/DebugInfo/constant-sdnodes-have-dbg-location.ll
  test/DebugInfo/constantfp-sdnodes-have-dbg-location.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9604.25314.patch
Type: text/x-patch
Size: 24598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150508/675546cc/attachment.bin>