[PATCH] [mips][microMIPSr6] Implement ALUIPC and AUIPC instructions
Daniel Sanders
daniel.sanders at imgtec.com
Fri May 8 03:39:48 PDT 2015
LGTM with a nit
================
Comment at: test/MC/Disassembler/Mips/micromips32r6.txt:12-17
@@ -11,2 +11,8 @@
+# CHECK: aluipc $3, 56
+0x78 0x7f 0x00 0x38
+
+# CHECK: auipc $3, -1
+0x78 0x7e 0xff 0xff
+
# CHECK: balc 14572256
----------------
Nit: Please use the single-line style.
Could you also fix the ones that have been committed in the multi-line style and delete the blank lines in a follow-up commit? No need for a review on that style correction commit
http://reviews.llvm.org/D8441
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list