[PATCH] ARM: generation of .ARM.exidx/.ARM.extab sections

Denis Protivensky dprotivensky at accesssoftek.com
Fri May 8 01:03:03 PDT 2015


LGTM with nits.


REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h:23
@@ -22,1 +22,3 @@
 
+/// ARM specific section (.ARM.exidx) with indexes to exception handlers
+class ARMExidxSection : public AtomSection<ELF32LE> {
----------------
/// \brief ARM ...

================
Comment at: lib/ReaderWriter/ELF/ExecutableWriter.h:29
@@ -28,2 +28,3 @@
 protected:
+  void startEnd(StringRef sym, StringRef sec);
   void buildDynamicSymbolTable(const File &file) override;
----------------
Please, consider more meaningful name.

http://reviews.llvm.org/D9324

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list