[PATCH] [DebugInfo] Add debug locations to constant SD nodes

[Matt Arsenault]

REPOSITORY
  rL LLVM

================
Comment at: llvm/trunk/include/llvm/CodeGen/SelectionDAG.h:423-426
@@ -425,1 +422,6 @@
+  SDValue getIntPtrConstant(uint64_t Val, SDLoc DL, bool isTarget = false);
+  SDValue getTargetConstant(uint64_t Val, SDLoc DL, EVT VT,
+                            bool isOpaque = false) {
+    return getConstant(Val, DL, VT, true, isOpaque);
   }
+  SDValue getTargetConstant(const APInt &Val, SDLoc DL, EVT VT,
----------------
Why do target constants need a debug location? The point of them is they aren't materialized in registers, and will eventually be embedded in an instruction. Should this skip the parameter for getTargetConstant and just use a null SDLoc?

http://reviews.llvm.org/D9084

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/