[PATCH] SanitizerCoverage: Use `createSanitizerCtor` to create ctor and call init

Alexey Samsonov vonosmas at gmail.com
Thu May 7 14:31:28 PDT 2015


LGTM


================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:271
@@ +270,3 @@
+
+  Function *CtorFunc = nullptr;
+  std::tie(CtorFunc, SanCovModuleInit) = createSanitizerCtorAndInitFunctions(
----------------
No need to initialize this variable, as it should be initialized by subsequent call.

================
Comment at: lib/Transforms/Instrumentation/SanitizerCoverage.cpp:272
@@ +271,3 @@
+  Function *CtorFunc = nullptr;
+  std::tie(CtorFunc, SanCovModuleInit) = createSanitizerCtorAndInitFunctions(
+      M, kSanCovModuleCtorName, kSanCovModuleInitName,
----------------
Note that SanCovModuleInit is not used anywhere, maybe you can also turn it into a local variable, and delete the class member?

http://reviews.llvm.org/D8780

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list