[PATCH] [sanitizer][MIPS] Add --target flag for MIPS32

Alexey Samsonov vonosmas at gmail.com
Thu May 7 11:32:59 PDT 2015


Alright, so here's the problem: `get_target_flags_for_arch` is used in two places:

1. Fetching flags eventually passed to `clang_compile` macro to build unit tests. They *should* be represented as list, as `clang_compile` description clearly says.
2. Fetching flags passed to clang in lit-tests (through `ASAN_TEST_TARGET_CFLAGS` CMake variable, which is used while configuring `lit.site.cfg.in`. They should be represented in a string form (space-separated).

Working with lists is generally more convenient, so let's return to http://reviews.llvm.org/differential/diff/25012/, and correct the usage of `get_target_flags_for_arch` while generating lit configs. I'm OK with replacing ";" with space. Also note, that you should only do this when you actually call `get_target_flags_for_arch`, not when you obtain these flags from `COMPILER_RT_TEST_COMPILER_CFLAGS` variable, which is likely a string. A comment in `get_target_flags_for_arch`, specifying that it returns a *list* would also be convenient.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9249

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list