[PATCH] [tablegen] Resolve complex def identifiers when instanciating multiclass

Amaury SECHET deadalnix+llvmreview at gmail.com
Wed May 6 20:51:10 PDT 2015


================
Comment at: lib/TableGen/TGParser.cpp:2428
@@ +2427,3 @@
+    // Check if the name is a complex pattern.
+    // If yes, resolve !
+    DefName = CurRec->getNameInit();
----------------
hfinkel wrote:
> If so, resolve it.
Well that why we have plenty of green code below.

================
Comment at: test/TableGen/MultiClassDefName.td:47
@@ +46,3 @@
+defm : MC3<"Buzz">;
+
+// CHECK: def ZFizzBuzz
----------------
silvas wrote:
> hfinkel wrote:
> > Can you please add a test with both a strong concatenation and also a concatenation with NAME?
> Also, the case where the template argument is a complex type. E.g.:
> 
> ```
> multiclass MC3<Foo f> {
>   def ZFizz#f.s : C<f.s>;
> }
> ```
What do you mean by strong concatenation ?

http://reviews.llvm.org/D9466

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list