[PATCH] Merge metadata in the AliasSetTracker (and refactor merging)

Philip Reames listmail at philipreames.com
Wed May 6 17:28:20 PDT 2015


================
Comment at: include/llvm/IR/Metadata.h:549
@@ -548,1 +548,3 @@
 
+  void merge(const AAMDNodes &N);
+
----------------
Documentation?  

================
Comment at: lib/Analysis/TypeBasedAliasAnalysis.cpp:626
@@ -625,1 +625,3 @@
 
+void AAMDNodes::merge(const AAMDNodes &N) {
+  TBAA = MDNode::getMostGenericTBAA(TBAA, N.TBAA);
----------------
Given the implementation, I'd be tempted to have this return a new merged AAMDNodes structure. e.g.
AAMDNodes merge(const AAMDNodes &LHS, const AAMDNodes& RHS) { .. }

http://reviews.llvm.org/D9396

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list