[PATCH] Let llc and opt override "-target-cpu" and "-target-features" using command line options "-mcpu" and "-mattr"

[Eric Christopher]

I agree, no TargetOptions for this. I don't necessarily agree with rewriting, but it seems to be a small enough change and will work for what the overrides are meant to be for. Some discipline in reviewing testcases to make sure that a lot of overrides aren't there for incoming testcases is going to be necessary for clean tests. One inline comment which basically sums up to "why not two functions"? As long as you have a reasonable answer go ahead.

Thanks!

-eric


================
Comment at: include/llvm/CodeGen/CommandFlags.h:268
@@ -262,1 +267,3 @@
 
+static inline std::pair<std::string, std::string> getCPUFeaturesStr() {
+  std::string CPUStr;
----------------
Why a pair?

http://reviews.llvm.org/D9537

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/