[PATCH] ARM: generation of .ARM.exidx/.ARM.extab sections

[Denis Protivensky]

REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMExecutableWriter.h:76
@@ +75,3 @@
+  // Set required by gcc libc symbols __exidx_start/__exidx_end
+  auto startEnd = [&](StringRef sym, StringRef sec) -> void {
+    std::string start = ("__" + sym + "_start").str();
----------------
That's now copy'n'pasting of the functionality. I actually wanted you to convert base class's lambda into member method and call it from here. Please, remove code duplication.

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMTargetHandler.h:23
@@ -22,1 +22,3 @@
 
+// ARM specific section (.ARM.exidx) with indexes to exception handlers
+class ARMExidxSection : public AtomSection<ELF32LE> {
----------------
It should be a doxygen-style comment. See here: http://llvm.org/docs/CodingStandards.html#commenting

http://reviews.llvm.org/D9324

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/