[PATCH] Thumb2SizeReduction: Check the correct set of registers for LDMIA.

Renato Golin renato.golin at linaro.org
Tue May 5 11:38:23 PDT 2015


In http://reviews.llvm.org/D9485#166124, @pcc wrote:

> The call is in `Thumb2SizeReduce::ReduceSpecial` (see line 566 in new code) before the call to `ReduceLoadStore`.


Ah, yes, I thought so. What you could do at least is to replace the test into an assert, so that we can catch the odd cases in the future in the case someone decide to call the same function without validating first. And also for documentation. :)

With the assert, LGTM. Thanks!


http://reviews.llvm.org/D9485

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list