LGTM with one comment... I'm guessing there isn't a good reason for the constructor to be defined inline: RegsForValue(LLVMContext &Context, const TargetLowering &tli, unsigned Reg, Type *Ty) {} http://reviews.llvm.org/D9478 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/