[PATCH] Fix parsing armv{6,7}hl triples

Jonathan Roelofs jonathan at codesourcery.com
Mon May 4 06:59:53 PDT 2015



On 4/27/15 4:21 AM, İsmail Dönmez wrote:
> Hi,
>
> This fixes a regression in failing to parse armv7hl-* and armv6hl-*
> triples. Most notably SUSE and Redhat uses those
> (armv7hl-suse-linux-gnueabi ...). Not sure how to test this though.

Have you looked at unittest/ADT/TripleTest.cpp ?

With a testcase, LGTM.

> Since StringSwitch accepts at most 5 arguments I had to split the v6
> lines.

I've always wondered why that isn't a variadic template function...


Cheers,

Jon

>
> Also should be applied to 3.6.1
>
> Please review.
>
> ismail
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded




More information about the llvm-commits mailing list