Please use the LLVM naming conventions for variables. Please use a range based for loop. I would prefer EXPECT_NE here rather than ASSERT_NE. http://reviews.llvm.org/D9441 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/