[PATCH] Add support for running lldb-test on android targets
Ying Chen
chying at google.com
Fri May 1 15:47:38 PDT 2015
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:347
@@ -315,1 +346,3 @@
+ terminatecmd = []
+ cleandircmd=''
# rsync
----------------
sivachandra wrote:
> Nit: Python variables "leak" out of scope. Hence, you do not need lines 344-347.
Thanks, It's good to know.
================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:404
@@ -328,1 +403,3 @@
+ haltOnFailure=True,
+ workdir='%s' % llvm_builddir))
# launch lldb-server
----------------
sivachandra wrote:
> Seems like there should be an 'else' case which just returns 'f'. Not that it matters in the current state of affairs, but it seems like a hole in the logic. For, if the platform is neither linux nor android, you will still go ahead and add other steps. I am not sure if this is OK.
This case will be handled in the beginning of this function,
' # only supports linux and android as remote target at this time
if remote_config.platform not in ('linux', 'android'):
return f '
http://reviews.llvm.org/D9354
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list