[PATCH] Update YamlIO documentation for ScalarTraits

Justin Bogner mail at justinbogner.com
Fri May 1 10:27:20 PDT 2015


Alex Lorenz <arphaman at gmail.com> writes:
> This patch updates the documentation for ScalarTraits by adding the
> missing context parameter to the output and input method.

This is obvious, you don't need pre-commit review for this kind of
simple documentation fix. Please commit.

> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D9173
>
> Files:
>   docs/YamlIO.rst
>
> Index: docs/YamlIO.rst
> ===================================================================
> --- docs/YamlIO.rst
> +++ docs/YamlIO.rst
> @@ -456,10 +456,10 @@
>  
>      template <>
>      struct ScalarTraits<MyCustomType> {
> -      static void output(const T &value, llvm::raw_ostream &out) {
> +      static void output(const T &value, void*, llvm::raw_ostream &out) {
>          out << value;  // do custom formatting here
>        }
> -      static StringRef input(StringRef scalar, T &value) {
> +      static StringRef input(StringRef scalar, void*, T &value) {
>          // do custom parsing here.  Return the empty string on success,
>          // or an error message on failure.
>          return StringRef();
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list