[llvm] r235989 - Reapply r235977 "[DebugInfo] Add debug locations to constant SD nodes"

Renato Golin renato.golin at linaro.org
Fri May 1 08:26:33 PDT 2015


On 1 May 2015 at 15:53, Keith Walker <kwalker at arm.com> wrote:
> But after this change there is a "spurious" line entry for the instruction
> at 0x18 loading the constant 0 which is incorrectly associated with the line
> 6.

>From the size of the change, this looks like a bad assumption in one
of the unrelated SDLocs.

Why haven't you added "SDLoc DL," to the end of the list of arguments?
It'd have made the patch a lot smaller and simpler.

cheers,
--renato



More information about the llvm-commits mailing list