[PATCH] Processes that spawn other processes should wait for their children to exit before exiting due to a signal.
David Majnemer
david.majnemer at gmail.com
Thu Apr 30 15:20:01 PDT 2015
================
Comment at: lib/Support/Unix/Program.inc:187
@@ +186,3 @@
+static void WaitForChildren(void *) {
+ if(ChildPIDs.isConstructed())
+ for (auto PI : *ChildPIDs)
----------------
You need a space between the if and the paren.
================
Comment at: lib/Support/Unix/Program.inc:189
@@ +188,3 @@
+ for (auto PI : *ChildPIDs)
+ Wait(PI, 0, true, nullptr);
+ ChildPIDs->clear();
----------------
Might be nice to do something like:
Wait(PI, /*SecondsUntilTerminate=*/0, /*WaitUntilTerminate=*/true, /*ErrMsg=*/nullptr);
I find that bare constants in function parameters can be confusing without a little context.
http://reviews.llvm.org/D9420
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list