[PATCH] Emit comment for gc.relocate's showing base and derived pointers in human readable form

Igor Laevsky igor at azulsystems.com
Thu Apr 30 04:05:53 PDT 2015


Duncan, could you please take a look at this changes? I am asking you because I am seeing a lot of submits from you to AsmParser lately. Please correct me if you are the wrong person to ask.

Philip, by using AnnotationWriter I can achieve same thing only for calls to which we explicitly pass AnnotationWriter. And there is no default AnnotationWriter. Because of this, for example, calls to Value->dump() will not emit intended comments. Also -print-after-all will  not emit them. This will reduce usability of this feature.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9326

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list