[PATCH] Sparc: support the "set" synthetic instruction.
James Y Knight
jyknight at google.com
Wed Apr 29 13:23:41 PDT 2015
================
Comment at: lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:81
@@ +80,3 @@
+
+ void ExpandSET(MCInst &Inst, SMLoc IDLoc,
+ SmallVectorImpl<MCInst> &Instructions,
----------------
venkatra wrote:
> Change the function name to expandSET().
>
> According to the coding standard, function names should start with lower case.
Done.
================
Comment at: lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:438
@@ +437,3 @@
+ // the imm operand can be either an expression or an immediate.
+ bool IsImm = Inst.getOperand(1).isImm();
+ uint64_t ImmValue = IsImm ? Inst.getOperand(1).getImm() : 0;
----------------
venkatra wrote:
> Use MCValOp itself.
Done.
http://reviews.llvm.org/D9089
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list