[compiler-rt] r235961 - Address old FIXMEs in UBSan test cases.

[Ahmed Bougacha]

On Mon, Apr 27, 2015 at 6:29 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:
> Author: samsonov
> Date: Mon Apr 27 20:29:36 2015
> New Revision: 235961
>
> URL: http://llvm.org/viewvc/llvm-project?rev=235961&view=rev
> Log:
> Address old FIXMEs in UBSan test cases.
>
> Modified:
>     compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
>     compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp
>
> Modified: compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp?rev=235961&r1=235960&r2=235961&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp (original)
> +++ compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp Mon Apr 27 20:29:36 2015
> @@ -1,4 +1,3 @@
> -// FIXME: run this (and other) UBSan tests in both 32- and 64-bit modes (?).
>  // RUN: %clangxx -fsanitize=float-cast-overflow -g %s -o %t
>  // RUN: %run %t _
>  // RUN: env UBSAN_OPTIONS=print_summary=1 %run %t 0 2>&1 | FileCheck %s --check-prefix=CHECK-0
>
> Modified: compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp?rev=235961&r1=235960&r2=235961&view=diff
> ==============================================================================
> --- compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp (original)
> +++ compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp Mon Apr 27 20:29:36 2015
> @@ -23,8 +23,6 @@
>  // RUN: echo "vptr_check:S" > %t.loc-supp
>  // RUN: UBSAN_OPTIONS="suppressions='%t.loc-supp':halt_on_error=1" not %run %t x- 2>&1 | FileCheck %s --check-prefix=CHECK-LOC-SUPPRESS
>
> -// FIXME: This test produces linker errors on Darwin.
> -// XFAIL: darwin

Hi Alexey,

Seems like this test still doesn't pass on Darwin, though for reasons
other than "linker errors";  see e.g.:

    http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/3415/testReport/junit/UBSan-Standalone-x86_64/TestCases_TypeCheck/vptr_cpp/

(and all following builds on that bot.)  Can you have a look?

Thanks!
-Ahmed

>  // REQUIRES: stable-runtime
>  #include <new>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits