[PATCH] propagate IR-level fast-math-flags to DAG nodes

Sanjay Patel spatel at rotateright.com
Tue Apr 28 08:41:28 PDT 2015


In http://reviews.llvm.org/D8900#162327, @echristo wrote:

> It's still my preference if possible because it'll take the API nfc change out of the mix on the patch. Is it possible for you to do that?


Hi Eric -

Sure - it's a little more work, but it's the right thing to do. I think we should actually break this into 3 steps:

1. Introduce the new Flags struct and have the existing BinaryWithFlagsSDNode use them only for nsw/nuw/exact (NFC).
2. Convert BinaryWithFlagsSDNode to the broader SDNodeWithFlags class and extend the potential users to the FP nodes (NFC).
3. Update DAGCombiner to use the 'arcp' flag and add the new test cases.

First patch coming up...


http://reviews.llvm.org/D8900

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list