[PATCH] [ARM] Teach the ARM Load Store Optimizer to collapse ldr/str's to ldrd/strd's

Renato Golin renato.golin at linaro.org
Tue Apr 28 05:30:29 PDT 2015


I agree with John, would be much better if this code was an extension, not a copy of the current machinery.

> I've adapted code from the AArch64 Load Store Optimizer to implement this optimization in the ARM Load Store Optimizer and I've kept the comments the same in some places.


Can you be more specific about what you adapted? Keeping the same comment in the same places is not always the correct thing to do, but more importantly, copy&paste is most definitely not the right thing to do.

cheers,
--renato


http://reviews.llvm.org/D9298

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list