[PATCH] Add sparc_le architecture (little-endian 32-bit Sparc).

Douglas Katzman dougk at google.com
Mon Apr 27 10:31:34 PDT 2015


factored out the changes to Triple as requested - http://reviews.llvm.org/D9263


================
Comment at: lib/Target/Sparc/MCTargetDesc/SparcMCTargetDesc.cpp:54
@@ -53,1 +53,3 @@
 
+static MCAsmInfo *createSparc_leMCAsmInfo(const MCRegisterInfo &MRI,
+                                       StringRef TT) {
----------------
jyknight wrote:
> Why a new copy of this? Shouldn't it just use createSparcMCAsmInfo?
Done

================
Comment at: lib/Target/Sparc/SparcTargetMachine.cpp:29
@@ +28,3 @@
+static std::string computeDataLayout(const Triple &T,
+				     bool is64Bit, char endianness) {
+  // Sparc is typically big endian, but some are little.
----------------
jyknight wrote:
> Perhaps less confusing to just have a bool isLittleEndian instead of a char passed in here?
Done

http://reviews.llvm.org/D8741

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list