[PATCH] [mips] [IAS] Fix expansion of negative 32-bit immediates for LI/DLI.
Toma Tabacu
toma.tabacu at imgtec.com
Mon Apr 27 08:26:32 PDT 2015
Replied to inline comments.
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1755
@@ -1753,3 +1754,3 @@
// | | | |
// | 16-bytes | 16-bytes | 16-bytes |
// |__________|__________|__________|
----------------
dsanders wrote:
> I know this isn't from your patch but I just noticed it. Shouldn't these be '16-bits'?
Yes. Fixed in r235891.
================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1780
@@ -1778,3 +1779,3 @@
// | | | | |
// | 16-bytes | 16-bytes | 16-bytes | 16-bytes |
// |__________|__________|__________|__________|
----------------
dsanders wrote:
> Same here
Yes. Fixed in r235891.
http://reviews.llvm.org/D8662
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list