[PATCH] [sanitizer][MIPS] Add --target flag for MIPS32
Sagar Thakur
Sagar.Thakur at imgtec.com
Mon Apr 27 02:56:55 PDT 2015
I am able to give multiple flags to `test_target_arch` function.
But with this the tests under AddressSanitizer-mips64-linux don't get the flags properly.
Since cmake list elements are glued with a semicolon, this semicolon gets inserted in between the two mips flags which divides the compile command into two parts. Therefore I have replaced this semicolon in `get_target_flags_for_arch` function with a tab.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D9249
Files:
cmake/config-ix.cmake
Index: cmake/config-ix.cmake
===================================================================
--- cmake/config-ix.cmake
+++ cmake/config-ix.cmake
@@ -184,11 +184,11 @@
# FIXME: Ideally, we would build the N32 library too.
if("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "mipsel|mips64el")
# regex for mipsel, mips64el
- test_target_arch(mipsel "" "-mips32r2")
- test_target_arch(mips64el "" "-mips64r2 -mabi=n64")
+ test_target_arch(mipsel "" "-mips32r2" "--target=mipsel-linux-gnu")
+ test_target_arch(mips64el "" "-mips64r2" "-mabi=n64")
else()
- test_target_arch(mips "" "-mips32r2")
- test_target_arch(mips64 "" "-mips64r2 -mabi=n64")
+ test_target_arch(mips "" "-mips32r2" "--target=mips-linux-gnu")
+ test_target_arch(mips64 "" "-mips64r2" "-mabi=n64")
endif()
elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "arm")
test_target_arch(arm "" "-march=armv7-a")
@@ -219,6 +219,7 @@
if(ARCH_INDEX EQUAL -1)
message(FATAL_ERROR "Unsupported architecture: ${arch}")
else()
+ string(REPLACE ";" "\t" TARGET_${arch}_CFLAGS "${TARGET_${arch}_CFLAGS}")
set(${out_var} ${TARGET_${arch}_CFLAGS} PARENT_SCOPE)
endif()
endfunction()
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9249.24461.patch
Type: text/x-patch
Size: 1223 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150427/fade18ce/attachment.bin>
More information about the llvm-commits
mailing list