[PATCH] Make llvm-symbolizer work on Windows.

Alexey Samsonov vonosmas at gmail.com
Fri Apr 24 15:39:28 PDT 2015


LGTM. There are a few minor comments below, feel free to land after addressing them. Thank you!


================
Comment at: test/tools/llvm-symbolizer/pdb/Inputs/addresses.txt:1
@@ +1,2 @@
+0x401020
+0x401030
----------------
Probably filename should reflect that these are addresses in test.exe

================
Comment at: test/tools/llvm-symbolizer/pdb/Inputs/addresses.txt:4
@@ +3,1 @@
+0x500000
\ No newline at end of file

----------------
missing newline?

================
Comment at: test/tools/llvm-symbolizer/pdb/Inputs/test.c:1
@@ +1,2 @@
+void foo() {
+}
----------------
Could you provide comment with brief instruction on how to build test.exe / test.pdf from it?

================
Comment at: test/tools/llvm-symbolizer/pdb/pdb.test:9
@@ +8,1 @@
+CHECK-NEXT: ??:0:0
\ No newline at end of file

----------------
missing newline

================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:20
@@ -19,1 +19,3 @@
 #include "llvm/ADT/StringRef.h"
+#include "llvm/Config/config.h"
+#include "llvm/Support/COM.h"
----------------
config.h is probably not needed now?

http://reviews.llvm.org/D9234

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list