[llvm] r235764 - IR: Remove MDMapTy and MDPairTy typedefs, NFC
Duncan P. N. Exon Smith
dexonsmith at apple.com
Fri Apr 24 13:19:13 PDT 2015
Author: dexonsmith
Date: Fri Apr 24 15:19:13 2015
New Revision: 235764
URL: http://llvm.org/viewvc/llvm-project?rev=235764&view=rev
Log:
IR: Remove MDMapTy and MDPairTy typedefs, NFC
Remove some typedefs in preparation for factoring out attachment logic
from `Instruction`.
Modified:
llvm/trunk/lib/IR/LLVMContextImpl.h
llvm/trunk/lib/IR/Metadata.cpp
Modified: llvm/trunk/lib/IR/LLVMContextImpl.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/LLVMContextImpl.h?rev=235764&r1=235763&r2=235764&view=diff
==============================================================================
--- llvm/trunk/lib/IR/LLVMContextImpl.h (original)
+++ llvm/trunk/lib/IR/LLVMContextImpl.h Fri Apr 24 15:19:13 2015
@@ -951,11 +951,10 @@ public:
/// CustomMDKindNames - Map to hold the metadata string to ID mapping.
StringMap<unsigned> CustomMDKindNames;
- typedef std::pair<unsigned, TrackingMDNodeRef> MDPairTy;
- typedef SmallVector<MDPairTy, 2> MDMapTy;
-
/// Collection of per-instruction metadata used in this context.
- DenseMap<const Instruction *, MDMapTy> InstructionMetadata;
+ DenseMap<const Instruction *,
+ SmallVector<std::pair<unsigned, TrackingMDNodeRef>, 2>>
+ InstructionMetadata;
/// DiscriminatorTable - This table maps file:line locations to an
/// integer representing the next DWARF path discriminator to assign to
Modified: llvm/trunk/lib/IR/Metadata.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Metadata.cpp?rev=235764&r1=235763&r2=235764&view=diff
==============================================================================
--- llvm/trunk/lib/IR/Metadata.cpp (original)
+++ llvm/trunk/lib/IR/Metadata.cpp Fri Apr 24 15:19:13 2015
@@ -997,8 +997,7 @@ void Instruction::dropUnknownMetadata(Ar
if (!hasMetadataHashEntry())
return; // Nothing to remove!
- DenseMap<const Instruction *, LLVMContextImpl::MDMapTy> &InstructionMetadata =
- getContext().pImpl->InstructionMetadata;
+ auto &InstructionMetadata = getContext().pImpl->InstructionMetadata;
if (KnownSet.empty()) {
// Just drop our entry at the store.
@@ -1007,7 +1006,7 @@ void Instruction::dropUnknownMetadata(Ar
return;
}
- LLVMContextImpl::MDMapTy &Info = InstructionMetadata[this];
+ auto &Info = InstructionMetadata[this];
unsigned I;
unsigned E;
// Walk the array and drop any metadata we don't know.
@@ -1045,8 +1044,7 @@ void Instruction::setMetadata(unsigned K
// Handle the case when we're adding/updating metadata on an instruction.
if (Node) {
- LLVMContextImpl::MDMapTy &Info =
- getContext().pImpl->InstructionMetadata[this];
+ auto &Info = getContext().pImpl->InstructionMetadata[this];
assert(!Info.empty() == hasMetadataHashEntry() &&
"HasMetadata bit is wonked");
if (Info.empty()) {
@@ -1072,8 +1070,7 @@ void Instruction::setMetadata(unsigned K
"HasMetadata bit out of date!");
if (!hasMetadataHashEntry())
return; // Nothing to remove!
- LLVMContextImpl::MDMapTy &Info =
- getContext().pImpl->InstructionMetadata[this];
+ auto &Info = getContext().pImpl->InstructionMetadata[this];
// Common case is removing the only entry.
if (Info.size() == 1 && Info[0].first == KindID) {
@@ -1106,8 +1103,7 @@ MDNode *Instruction::getMetadataImpl(uns
if (!hasMetadataHashEntry()) return nullptr;
- LLVMContextImpl::MDMapTy &Info =
- getContext().pImpl->InstructionMetadata[this];
+ auto &Info = getContext().pImpl->InstructionMetadata[this];
assert(!Info.empty() && "bit out of sync with hash table");
for (const auto &I : Info)
@@ -1130,8 +1126,7 @@ void Instruction::getAllMetadataImpl(
assert(hasMetadataHashEntry() &&
getContext().pImpl->InstructionMetadata.count(this) &&
"Shouldn't have called this");
- const LLVMContextImpl::MDMapTy &Info =
- getContext().pImpl->InstructionMetadata.find(this)->second;
+ const auto &Info = getContext().pImpl->InstructionMetadata.find(this)->second;
assert(!Info.empty() && "Shouldn't have called this");
Result.reserve(Result.size() + Info.size());
@@ -1149,8 +1144,7 @@ void Instruction::getAllMetadataOtherTha
assert(hasMetadataHashEntry() &&
getContext().pImpl->InstructionMetadata.count(this) &&
"Shouldn't have called this");
- const LLVMContextImpl::MDMapTy &Info =
- getContext().pImpl->InstructionMetadata.find(this)->second;
+ const auto &Info = getContext().pImpl->InstructionMetadata.find(this)->second;
assert(!Info.empty() && "Shouldn't have called this");
Result.reserve(Result.size() + Info.size());
for (auto &I : Info)
More information about the llvm-commits
mailing list