[llvm] r235635 - [Hexagon] Fix compiler warnings in release build

Aaron Ballman aaron at aaronballman.com
Thu Apr 23 13:36:22 PDT 2015


On Thu, Apr 23, 2015 at 4:34 PM, Krzysztof Parzyszek
<kparzysz at codeaurora.org> wrote:
> On 4/23/2015 3:31 PM, Aaron Ballman wrote:
>>
>> On Thu, Apr 23, 2015 at 4:26 PM, Krzysztof Parzyszek
>> <kparzysz at codeaurora.org> wrote:
>>>
>>>     if (RetOpc == Hexagon::EH_RETURN_JMPR) {
>>>       MachineOperand &OffsetReg  = RetI->getOperand(0);
>>> +    (void)OffsetReg; // Silence compiler warning.
>>>       assert(OffsetReg.isReg() && "Offset should be in register!");
>>
>>
>> Any reason not to remove OffsetReg entirely and just call
>> RetI->getOperand(0).isReg() in the assert?
>
>
> No. I guess there was more stuff there but got removed and we ended up with
> a single use in an assert.
>
> I'll clean it up in a future patch.

Thank you!

~Aaron



More information about the llvm-commits mailing list