[PATCH] [MC] [IAS] Add support for the \@ .macro pseudo-variable.

Toma Tabacu toma.tabacu at imgtec.com
Thu Apr 23 05:12:43 PDT 2015


In http://reviews.llvm.org/D9197#160307, @rafael wrote:

> The documentation in gas says @ is " how many macros it has executed ". Is the documentation wrong?


No, the documentation is right, I just got too focused on an ambiguous test-case. Sorry about that!
I think it's supposed to track the number of .macro instantiations we've made up to that point.

> In particular, can you test for a macro being undefined and the number going down?


I don't think this applies anymore, as the number of instantiations can't go down.

> Also, you check for \@ in two locations (two ifs use EnableAtPseudoVariable), but the test only covers one of them, no?


That second check is redundant AFAICT, as Argument can only be "@" if the first check succeeds, so I removed it.


http://reviews.llvm.org/D9197

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list