[PATCH] ARM: Only enforce 4-byte alignment on Thumb-2 functions with constant pools.

Peter Collingbourne peter at pcc.me.uk
Wed Apr 22 11:18:44 PDT 2015


================
Comment at: lib/Target/ARM/ARMConstantIslandPass.cpp:416
@@ -415,3 @@
-  // Thumb1 functions containing constant pools get 4-byte alignment.
-  // This is so we can keep exact track of where the alignment padding goes.
-
----------------
rengolin wrote:
> This is not just about standard Thumb alignment, but Thumb functions with constant pools, which are also expected to align 4, if memory serves me right. Is that what you're testing down there on your new test?
> 
> I wonder if that's going to open an old corner case...
> This is not just about standard Thumb alignment, but Thumb functions with constant pools, which are also expected to align 4, if memory serves me right.

Exactly. We are now only setting the alignment in cases where a constant pool makes it necessary (see lines 504-508 of the new file). I've retitled the change to make this clear.

> Is that what you're testing down there on your new test?

Yes.

http://reviews.llvm.org/D9138

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list