[llvm] r235480 - Revert r235219, it's not needed after r235450.

[Aaron Ballman]

Thank you, looks great!

~Aaron

On Wed, Apr 22, 2015 at 12:47 PM, Yaron Keren <yaron.keren at gmail.com> wrote:
> Committed revision 235522.
>
>
> 2015-04-22 19:11 GMT+03:00 Yaron Keren <yaron.keren at gmail.com>:
>>
>> Oops, sorry. I have updated the code locally, testing it and will commit
>> soon.
>> Also added your explaination why the pragma is needed.
>>
>>
>> 2015-04-22 18:10 GMT+03:00 Aaron Ballman <aaron at aaronballman.com>:
>>>
>>> Please revert this change; AlignOf.h is a published support header
>>> that's available for use out-of-tree, and we would like that to
>>> compile cleanly at /W4 even if we disable a warning project-wide.
>>>
>>> ~Aaron
>>>
>>> On Wed, Apr 22, 2015 at 1:06 AM, Yaron Keren <yaron.keren at gmail.com>
>>> wrote:
>>> > Author: yrnkrn
>>> > Date: Wed Apr 22 00:06:57 2015
>>> > New Revision: 235480
>>> >
>>> > URL: http://llvm.org/viewvc/llvm-project?rev=235480&view=rev
>>> > Log:
>>> > Revert r235219, it's not needed after r235450.
>>> >
>>> >
>>> > Modified:
>>> >     llvm/trunk/include/llvm/Support/AlignOf.h
>>> >
>>> > Modified: llvm/trunk/include/llvm/Support/AlignOf.h
>>> > URL:
>>> > http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/AlignOf.h?rev=235480&r1=235479&r2=235480&view=diff
>>> >
>>> > ==============================================================================
>>> > --- llvm/trunk/include/llvm/Support/AlignOf.h (original)
>>> > +++ llvm/trunk/include/llvm/Support/AlignOf.h Wed Apr 22 00:06:57 2015
>>> > @@ -22,11 +22,6 @@ namespace llvm {
>>> >  template <typename T>
>>> >  struct AlignmentCalcImpl {
>>> >    char x;
>>> > -#if defined(_MSC_VER)
>>> > -// Disables "structure was padded due to __declspec(align())" warnings
>>> > that are
>>> > -// generated by any class using AlignOf<T> with a manually specified
>>> > alignment.
>>> > -#pragma warning(suppress : 4324)
>>> > -#endif
>>> >    T t;
>>> >  private:
>>> >    AlignmentCalcImpl() {} // Never instantiate.
>>> >
>>> >
>>> > _______________________________________________
>>> > llvm-commits mailing list
>>> > llvm-commits at cs.uiuc.edu
>>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>