[PATCH] [WinEH] Demote values live across exception handlers up front

Reid Kleckner rnk at google.com
Wed Apr 22 09:09:55 PDT 2015


================
Comment at: lib/CodeGen/WinEHPrepare.cpp:417
@@ +416,3 @@
+                       << " with llvm.eh.endcatch\n");
+          BBI = BB->splitBasicBlock(&I);
+        }
----------------
andrew.w.kaylor wrote:
> Does this put the endcatch call in the split successor or leave it in the original block?
Good catch! This code splits before the call, but I didn't want that. It's not easy to observe in a test because we remove these calls and branches after outlining.

http://reviews.llvm.org/D9158

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list