[PATCH] ELF/ARM: Ignore R_ARM_V4BX for ARMv4 but allow linking
Rui Ueyama
ruiu at google.com
Tue Apr 21 12:47:31 PDT 2015
================
Comment at: lib/ReaderWriter/ELF/ELFFile.cpp:41
@@ -40,8 +40,3 @@
Atom *target = _symbolToAtomMapping.lookup(targetSym);
- if (target->definition() != Atom::definitionRegular)
- return target;
- Atom::Scope scope = llvm::cast<DefinedAtom>(target)->scope();
- if (scope == DefinedAtom::scopeTranslationUnit)
- return target;
- if (!redirectReferenceUsingUndefAtom(sourceSym, targetSym))
- return target;
+ if (target) {
+ if (target->definition() != Atom::definitionRegular)
----------------
if (Atom *target = _symbolToAtomMapping.lookup(targetSym)) {
================
Comment at: lib/ReaderWriter/ELF/ELFFile.cpp:52
@@ -49,3 +51,3 @@
// Otherwise, create a new undefined symbol and returns it.
StringRef targetName = target->name();
auto it = _undefAtomsForGroupChild.find(targetName);
----------------
When it reaches here, target can be null, no?
http://reviews.llvm.org/D9163
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list