[PATCH] Rename determineInsertionPoints to determinePHINodes, expose it so it can be reused
Daniel Berlin
dberlin at dberlin.org
Tue Apr 21 11:02:10 PDT 2015
On Tue, Apr 21, 2015 at 10:07 AM, Quentin Colombet <qcolombet at apple.com> wrote:
> Hi Daniel,
>
> Thanks for the refactoring!
>
> LGTM with a couple of nitpicks.
>
> Cheers,
> -Quentin
>
Comments being added :)
> Edit: I see that the comment is in the cpp file. I believe it would be more convenient to have it here. Also, does doxygen pick up the comments from the .cpp?
I'll move it, but i think it does pick it up (our documentation
guidelines imply it does)
More information about the llvm-commits
mailing list