[lld] r235393 - [ELF] Change return type of the OutputSection::flags() method

Simon Atanasyan simon at atanasyan.com
Tue Apr 21 10:02:50 PDT 2015


Author: atanasyan
Date: Tue Apr 21 12:02:49 2015
New Revision: 235393

URL: http://llvm.org/viewvc/llvm-project?rev=235393&view=rev
Log:
[ELF] Change return type of the OutputSection::flags() method

This method returns _flags field which has `uint64_t` type. Now the
field's type and the method's return type are consistent.

Modified:
    lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
    lld/trunk/lib/ReaderWriter/ELF/TargetLayout.cpp

Modified: lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h?rev=235393&r1=235392&r2=235393&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/SectionChunks.h Tue Apr 21 12:02:49 2015
@@ -259,7 +259,7 @@ public:
   uint64_t fileSize() const { return _size; }
   int64_t entsize() const { return _entSize; }
   uint64_t fileOffset() const { return _fileOffset; }
-  int64_t flags() const { return _flags; }
+  uint64_t flags() const { return _flags; }
   uint64_t memSize() { return _memSize; }
 
 private:

Modified: lld/trunk/lib/ReaderWriter/ELF/TargetLayout.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/TargetLayout.cpp?rev=235393&r1=235392&r2=235393&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/TargetLayout.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/TargetLayout.cpp Tue Apr 21 12:02:49 2015
@@ -362,7 +362,7 @@ template <class ELFT> void TargetLayout<
       section->setSegmentType(segmentType);
       StringRef segmentName = section->segmentKindToStr();
 
-      int64_t lookupSectionFlag = osi->flags();
+      uint64_t lookupSectionFlag = osi->flags();
       if ((!(lookupSectionFlag & llvm::ELF::SHF_WRITE)) &&
           (_ctx.mergeRODataToTextSegment()))
         lookupSectionFlag &= ~llvm::ELF::SHF_EXECINSTR;





More information about the llvm-commits mailing list