[PATCH] [ubsan] Stop cast-overflow.cpp test leaking undefined behaviour into the exit code.
Daniel Sanders
daniel.sanders at imgtec.com
Tue Apr 21 07:51:17 PDT 2015
ubsan was correctly catching the undefined behaviour but lit's shell was
failing the test anyway because the exit code was non-zero as a result of the
undefined behaviour.
This fixes the test on a mips-linux-gnu target.
http://reviews.llvm.org/D9155
Files:
test/ubsan/TestCases/Float/cast-overflow.cpp
Index: test/ubsan/TestCases/Float/cast-overflow.cpp
===================================================================
--- test/ubsan/TestCases/Float/cast-overflow.cpp
+++ test/ubsan/TestCases/Float/cast-overflow.cpp
@@ -87,9 +87,11 @@
static int test_int = MaxFloatRepresentableAsInt + 0x80;
return 0;
}
- case '1':
+ case '1': {
// CHECK-1: runtime error: value -2.14748{{.*}} is outside the range of representable values of type 'int'
- return MinFloatRepresentableAsInt - 0x100;
+ static int test_int = MinFloatRepresentableAsInt - 0x100;
+ return 0;
+ }
case '2': {
// CHECK-2: runtime error: value -1 is outside the range of representable values of type 'unsigned int'
volatile float f = -1.0;
@@ -107,9 +109,11 @@
static int test_int = Inf;
return 0;
}
- case '5':
+ case '5': {
// CHECK-5: runtime error: value {{.*}} is outside the range of representable values of type 'int'
- return NaN;
+ static int test_int = NaN;
+ return 0;
+ }
// Integer -> floating point overflow.
case '6': {
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9155.24134.patch
Type: text/x-patch
Size: 1081 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150421/688ed5eb/attachment.bin>
More information about the llvm-commits
mailing list