[PATCH] [DebugInfo] Add debug locations to constant SD nodes

Sergey Dmitrouk sdmitrouk at accesssoftek.com
Tue Apr 21 02:59:50 PDT 2015


In http://reviews.llvm.org/D9084#158680, @echristo wrote:

> The changed tests are very worrisome, it would be good to track this down.


I'll try to do this, although reordering appears quite innocent to me.

In http://reviews.llvm.org/D9084#158680, @echristo wrote:

> I'd have probably put DebugLoc after the type in most of the places, but I'm not sure it's worth having you rewrite the patch.


Before starting I looked through other `getSomething` methods of `SelectionDAG`, most of them seem (I didn't actually count) to have debug location before type, so I used the same order.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9084

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list