[PATCH] Move MachineValueType.h from CodeGen to MC

[Eric Christopher]

I don't think this makes sense in MC. It's largely used at the
DAG/MI/Lowering level and not in MC at all (by a quick grep).

-eric

On Mon, Apr 20, 2015 at 1:51 PM Pete Cooper <peter_cooper at apple.com> wrote:

> This would help :)
>
>
> > On Apr 20, 2015, at 1:37 PM, Pete Cooper <peter_cooper at apple.com> wrote:
> >
> > Hi all
> >
> > This patch moves MachineValueType.h from CodeGen to MC.  There are a few
> places in X86 MC level tools (assembly instrumentation, inst comments,
> shuffle decode) which include this file but shouldn’t due to layering
> violations.
> >
> > Given that I believe the M in MC stands for ‘Machine’, it makes sense to
> me that MachineValueType lives there too.  Its also a completely self
> contained header, so is relatively painless to move.
> >
> > I’ve updated all places which include this file and sorted the includes
> appropriately.  Let me know if there’s anything else to be done.
> >
> > I’ll send out a message to the list to make it clear to out of tree
> target owners that this could impact them, although its an easy thing to
> update if they have issues.
> >
> > Note, i also considered actually renaming it to MCValueType.h to match
> other MC headers, but ConstantPool.h already broke that convention.  I’m
> happy to do that in this commit or in a later one if anyone is strongly for
> the idea.
> >
> > Also, if this is approved i’ll do a separate commit to stop X86 MC tools
> from linking against X86 CodeGen.
> >
> > Cheers,
> > Pete
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150420/748d4d7d/attachment.html>