[PATCH] Set a debugger "target" to guide DWARF choices

Paul Robinson Paul_Robinson at playstation.sony.com
Mon Apr 20 11:51:43 PDT 2015


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:208
@@ -208,1 +207,3 @@
 
+  // Make sure we have a "debugger target."
+  if (Asm->TM.Options.Debugger == DebuggerKind::Any) {
----------------
aprantl wrote:
> Should we rename DebuggerKind::Any to TargetDefault or just Default?
"Default" works for me.  I originally had some vague notion about a generic target, so "Any," but getting that to work right is surely more trouble than it's worth.  "Default" better expresses that it will actually turn into something specific.

http://reviews.llvm.org/D8506

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list