[PATCH] Refactor identification of reductions and expose them as utility functions

Adam Nemet anemet at apple.com
Fri Apr 17 15:25:15 PDT 2015


I'll let Renato OK this, but there is one more thing I've noticed.  Thanks.


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:19-21
@@ -18,2 +18,5 @@
 #include "llvm/IR/Dominators.h"
+#include "llvm/IR/IRBuilder.h"
+#include "llvm/IR/Value.h"
+#include "llvm/IR/Constants.h"
 
----------------
It does not look like you tried to minimize the included headers by relying on forward decls.  See http://llvm.org/docs/CodingStandards.html#include-as-little-as-possible

http://reviews.llvm.org/D9046

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list