[PATCH] [DebugInfo] Add debug locations to constant SD nodes

[Sergey Dmitrouk]

REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/X86/2012-11-28-merge-store-alias.ll:6
@@ -5,3 +5,3 @@
 ; CHECK: xorps %xmm0, %xmm0
-; CHECK-NEXT: movups  %xmm0
+; CHECK: movups  %xmm0
 ; CHECK: callq foo
----------------
asl wrote:
> I'd assume now .loc is emitted in the middle? Can't we simple git rid of debug info the .ll ?
No, it's just reordering. One of instructions that were below now moved above.

================
Comment at: test/CodeGen/X86/sse41.ll:749
@@ -748,4 +748,3 @@
 ; X32:       ## BB#0:
-; X32-NEXT:    pshufd {{.*#+}} xmm1 = xmm0[0,1,2,0]
-; X32-NEXT:    pxor %xmm0, %xmm0
-; X32-NEXT:    pblendw {{.*#+}} xmm0 = xmm1[0,1],xmm0[2,3,4,5],xmm1[6,7]
+; X32-NEXT:    pxor %xmm1, %xmm1
+; X32-NEXT:    pshufd {{.*#+}} xmm0 = xmm0[0,1,2,0]
----------------
asl wrote:
> The changed order here looks weird... Any particular reason?
> Any particular reason?

No, but it doesn't seem to be wrong either. As if debug location affects some sorting, previously a lot of locations were empty, thus equal, and ordering was a bit different. It's not x86-specific, similar effect can be seen, say, for ARM, there is just no tests that expose it for other targets, but adding debug locations does affect order of instructions in some way.

http://reviews.llvm.org/D9084

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/