[PATCH] Add support to promote f16 to f32

Ahmed Bougacha ahmed.bougacha at gmail.com
Fri Apr 17 10:18:23 PDT 2015


I don't see anything missing; LGTM with a couple nits.

Thanks!


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:1595
@@ +1594,3 @@
+
+  assert (false && "Attempt at an invalid promotion-related conversion");
+  return ISD::DELETED_NODE;
----------------
report_fatal_error?

================
Comment at: test/CodeGen/ARM/fp16-promote.ll:1164
@@ +1163,3 @@
+; f16 vectors are not legal in the backend.  Vector elements are not assigned
+; to the register, but are tored in the stack instead.  Hence insertelement
+; and extractelement have these extra loads and stores.
----------------
tored -> stored

http://reviews.llvm.org/D8755

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list