[PATCH] AArch64 fast-isel generates incorrect results on big-endian vector call returns

James Molloy james at jamesmolloy.co.uk
Thu Apr 16 13:51:59 PDT 2015


Hi Pete,

This looks fine to me. It's interesting though because I thought we did
handle vector returns in fast-isel - emitting the bitcast conversion code.
But it's a long time ago and my brain has become dusty.

Cheers,

James

On Thu, 16 Apr 2015 at 21:19 Pete Cooper <peter_cooper at apple.com> wrote:

> Hi James
>
> This patch makes AArch64 fast-isel bail out if it sees a call which
> returns a vector result.
>
> The existing test case for this was covering up the failures because some
> store instructions missed fast-isel and so the calls were never actually
> selected in fast-isel.  I’ve inserted a branch in the BBs of all the tests
> to make the call be at the end of a BB and so always selected in
> fast-isel.  If you run the test without my C++ code too you’ll get the
> failures I was seeing.
>
> I’ve left a ‘TODO’ in there because someone should probably get fast-isel
> to support this, but i thought it best to get correct code before aiming
> for more coverage.
>
> Cheers
> Pete
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150416/a45d7209/attachment.html>


More information about the llvm-commits mailing list