[PATCH] Implement MUL, MUH, MULU and MUHU instructions
Daniel Sanders
daniel.sanders at imgtec.com
Thu Apr 16 01:38:13 PDT 2015
================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:25
@@ +24,3 @@
+class MUL_MMR6_ENC : ARITH_FM_MMR6<"mul", 0x18>;
+class MUH_MMR6_ENC : ARITH_FM_MMR6<"muh", 0x2c>;
+class MULU_MMR6_ENC : ARITH_FM_MMR6<"mulu", 0x98>;
----------------
dsanders wrote:
> I believe this is correct, but the encoding diagram only has 9-bits specified for this 10-bit field. Presumably is a leading zero is missing. I've asked the relevant people to confirm and correct the documentation.
I've had confirmation that it's actually a trailing zero that's missing so I believe this should be 0x58
http://reviews.llvm.org/D8894
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list