[PATCH] ARM: Update R_ARM_TARGET1 command line option names (remove prefix 'arm-')

Simon Atanasyan simon at atanasyan.com
Wed Apr 15 13:12:26 PDT 2015


LGTM


REPOSITORY
  rL LLVM

================
Comment at: lib/Driver/GnuLdDriver.cpp:549
@@ -548,3 +548,3 @@
       return false;
     } else if (hasArmTarget1Rel || hasArmTarget1Abs) {
       ctx->setArmTarget1Rel(hasArmTarget1Rel && !hasArmTarget1Abs);
----------------
This does not relate to this patch but the `else if` statement violates the "else after a return" rule:
http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return

================
Comment at: lib/Driver/GnuLdDriver.cpp:552
@@ -551,3 +551,3 @@
     }
   } else if (hasArmTarget1Rel) {
     diag << "warning: ignoring unsupported ARM/ELF specific argument: "
----------------
We can handle both `else if` statements below in a uniform way:
```
else {
  for (const auto *arg : parsedArgs->filtered(OPT_grp_arm_targetopts)) {
    diag << "warning: ignoring unsupported ARM/ELF specific argument: "
         << arg->getSpelling() << "\n";
  }
}
```

http://reviews.llvm.org/D9037

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list